Conversation
Releases go through trusted publishing, so no API key is stored anywhere and a push from CI needs no secret. That leaves the other door open: anyone holding a RubyGems credential for an owner of this gem can `gem push` from a laptop, and a leaked or reused token is enough. rubygems_mfa_required refuses that without a second factor. It costs nothing here, because the automated path does not use credentials at all. Also adds bug_tracker_uri and documentation_uri, so the RubyGems page points at the issue tracker and the README rather than only at the repo root. homepage_uri is deliberately not set: it would duplicate source_code_uri, and `gem build --strict` -- which the release workflow runs -- fails on that warning. Verified with `rake release:build`, which is the strict build the release workflow performs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases go through trusted publishing, so no API key is stored anywhere and a push from CI needs no secret. That leaves the other door open: anyone holding a RubyGems credential for an owner of this gem can
gem pushfrom a laptop, and a leaked or reused token is enough.rubygems_mfa_requiredrefuses that without a second factor. It costs nothing here, because the automated path doesn't use credentials at all.Also adds
bug_tracker_urianddocumentation_uri, so the RubyGems page points at the issue tracker and the README rather than only at the repo root.homepage_uriis deliberately not set: it would duplicatesource_code_uri, andgem build --strict— which the release workflow runs — fails on that warning. Verified withrake release:build, which is that exact strict build.Draft: part of a security and API-coverage audit, opened for reference rather than as a request for immediate review. Independent of the other branches, each off
main. Suite green on Ruby 3.2.11, 3.3.8 and 3.4.8.🤖 Generated with Claude Code