test(windows): fix process and checkout fixture portability - #1623
Merged
Teingi merged 1 commit intoSep 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #1501.
Rationale for this change
On Windows with long-path support disabled, six tests from #1501 still fail on master
0ed20c54: the three OpenCode probe cleanup assertions use POSIXos.kill(pid, 0)semantics, and three remote-checkout fixtures exceed the path limit under pytest's default temporary root. These are test portability defects, not evidence of broken product authorization or subprocess cleanup.What changes are included in this PR?
--basetempcannot mask fixture regressions. POSIX-only skips remain explicit.Are there any user-facing changes?
No runtime, API, dependency, or persisted-format changes. Windows contributors can run the affected tests with the default pytest temporary root.
How was this change tested?
Windows x64, CPython 3.12.13,
LongPathsEnabled=0:--basetemp. The skips cover POSIX permissions,O_NOFOLLOW, and symlink support.Additional validation:
uv run pytest -q tests/test_opencode_cli.py: 18 passed after the platform guard was added.uv run pytest -q tests/test_integration_manifest.py: 28 passed.uv lock --locked.uv run python scripts/check_workflow_actions.py .github/workflows .github/actions: 76 action references checked.uv run python scripts/generate_integration_manifest_docs.py --check.uv run ty check tests/conftest.py tests/test_opencode_cli.py tests/test_cli_workbuddy.py, also with--python-platform linux.uv run ty check integrations/pydantic-ai/src.--python-platform linux --exclude docs/my --exclude .t1494 --exclude .tmp-windows-path-1494; exclusions are pre-existing untracked local directories.uv run prek run -a: all hooks exceptty-checkpassed. Native Windows whole-repository type checking reports pre-existing errors in local document scripts and unrelated multiprocessing/POSIX annotations; changed-file Windows checks and the Linux-target repository check above passed.The hosted Windows CI job and Linux runtime matrix require CI execution; they were not run locally.
AI usage statement
OpenAI Codex (GPT-6) assisted with issue review, Windows reproduction, implementation, regression validation, and PR preparation.