Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

feat: add loading for alternative help classes - #85

Merged
chadian merged 10 commits into
masterfrom
cc/allow-alternative-help-plugins
May 1, 2020
Merged

feat: add loading for alternative help classes#85
chadian merged 10 commits into
masterfrom
cc/allow-alternative-help-plugins

Conversation

@chadian

@chadian chadian commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

This uses the latest version of @oclif/plugin-help to be able to dynamically load help classes which includes a fallback if it a custom help class is not specified.

@chadian
chadian force-pushed the cc/allow-alternative-help-plugins branch 2 times, most recently from e505973 to 55388c9 Compare April 2, 2020 18:42
Comment thread src/main.ts Outdated
Comment thread test/command.test.ts Outdated
@chadian
chadian force-pushed the cc/allow-alternative-help-plugins branch 2 times, most recently from 8e8d5b4 to 4a7dabb Compare April 3, 2020 15:15
Comment thread src/main.ts Outdated
Comment thread src/util.ts Outdated
@chadian
chadian force-pushed the cc/allow-alternative-help-plugins branch 2 times, most recently from 4013abf to c4869a7 Compare April 13, 2020 17:40
@chadian
chadian force-pushed the cc/allow-alternative-help-plugins branch 2 times, most recently from 457cc5f to 9d888b1 Compare April 20, 2020 19:48
@codecov

codecov Bot commented Apr 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #85 into master will decrease coverage by 65.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #85       +/-   ##
==========================================
- Coverage   65.40%   0.00%   -65.41%     
==========================================
  Files           5       1        -4     
  Lines         159      10      -149     
  Branches       35       2       -33     
==========================================
- Hits          104       0      -104     
+ Misses         36      10       -26     
+ Partials       19       0       -19     
Impacted Files Coverage Δ
src/index.ts 0.00% <0.00%> (-35.72%) ⬇️
src/flags.ts
src/util.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a686865...5348b19. Read the comment docs.

@chadian
chadian marked this pull request as ready for review April 21, 2020 22:37

@RasPhilCo RasPhilCo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

@chadian
chadian force-pushed the cc/allow-alternative-help-plugins branch from 44831a9 to df69de0 Compare April 27, 2020 20:47
@chadian chadian changed the title feat: add loading for alternative help plugin feat: add loading for alternative help classes Apr 27, 2020
@chadian
chadian force-pushed the cc/allow-alternative-help-plugins branch from df69de0 to 5348b19 Compare April 27, 2020 22:18
@chadian
chadian merged commit 136e7d4 into master May 1, 2020
@chadian
chadian deleted the cc/allow-alternative-help-plugins branch May 1, 2020 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants