feat: upping to eslint 10 (W-23473845) - #1635
Conversation
| } | ||
|
|
||
| export const readStdin = async (): Promise<null | string> => { | ||
| export const readStdin = async (): Promise<undefined | string> => { |
There was a problem hiding this comment.
I had to manually change some return nulls to return undefined. I determined that the export here is solely for testability, and all the internal usages are just if (!blah), so there's nothing to worry about with behavioral changes.
| /** | ||
| * ../config version | ||
| */ | ||
| _base: string |
There was a problem hiding this comment.
config/plugin.ts changed a property that was implicitly private (_base) to one that is explicitly private (#base), but that introduced a compile error due to the definition here.
It is Claude's (and also my) opinion that removing this property is safe to do, because it was not referenced anywhere except for internally, and it's an implicitly private property anyway.
| } | ||
|
|
||
| const hooks = p.hooks[event] || [] | ||
| const hooks = p.hooks[event as string] || [] |
There was a problem hiding this comment.
Had to manually add this to resolve another compile error.
|
|
||
| const gitignorePath = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '.gitignore') | ||
|
|
||
| // eslint disable-next-line import-x/no-anonymous-default-export |
There was a problem hiding this comment.
I don't really know why I manually suppressed this here instead of using the suppression file. It felt weird to implicitly suppress something in the eslint config itself. I want to call it "rude" for some reason?
dff784b to
248de04
Compare
Part of @W-23473845@.
Bumping
eslintto v10 andeslint-config-oclifto v7.x.Running
yarn lint --fixintroduced compile errors (which were easily fixed) and test failures (which were arcane nonsense that stymied me for hours). So I just decided to flatly suppress every violation.Suppression was done through a suppression.json file that grandfathers in all the existing violations.