Stop processing flag multiple when a non-option flag is found - #137
Stop processing flag multiple when a non-option flag is found#137firefish5000 wants to merge 4 commits into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @firefish5000 to sign the Salesforce.com Contributor License Agreement. |
|
Unrelated, but while reading the test I had to question why we have Also unrelated. Commits 120e121 and 76fa11c are just expansion of test cases. Not really part of this issue. These were things I needed to assure myself occurred in general and didn't see in the tests |
Currently, if we have a flag that accepts multiple values followed by a boolean flag and then positional arguments, the multiple flag will erroneously receive the arguments that come after the boolean flag. Example
myProg --extensions .js .ts --strict ./myDir1 ./myDir2 # extensions is set to [ '.js', '.ts', './myDir1', './myDir2' ]This PR changes that behavior so boolean flags end the parsing just like option flags do.
myProg --extensions .js .ts --strict ./myDir1 ./myDir2 # extensions is set to [ '.js', '.ts' ]Bug is due to
this.currentFlagnot being set for non-option (bool) flags in parse.ts lines 109-147