This repository was archived by the owner on Aug 22, 2023. It is now read-only.
feat(args): Support checking options after parse function - #163
Open
justinedelson wants to merge 2 commits into
Open
feat(args): Support checking options after parse function#163justinedelson wants to merge 2 commits into
justinedelson wants to merge 2 commits into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @justinedelson to sign the Salesforce.com Contributor License Agreement. |
Closed
justinedelson
force-pushed
the
issue/add-post-parse-options
branch
from
April 21, 2021 11:44
4ca95fc to
c8a511e
Compare
justinedelson
commented
Apr 21, 2021
| working_directory: ~/cli | ||
| environment: | ||
| NYC: "yarn exec nyc -- --nycrc-path node_modules/@oclif/nyc-config/.nycrc" | ||
| FORCE_COLOR: "0" |
Author
There was a problem hiding this comment.
This is really not related to this PR, but was necessary to get circle ci to pass. Happy to create a separate PR for this if desired.
Author
|
@heroku-cli Would it be possible for someone to review this? |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #162
Although this could be done differently by using the existing options, that seems like it might present a backwards compatibility issue so instead I added a new configuration item -- postParseOptions