This repository was archived by the owner on Aug 22, 2023. It is now read-only.
fix: move @oclif/errors from devDependencies to dependencies - #71
Merged
Conversation
|
Thanks for the contribution! Before we can merge this, we need @merceyz to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 91.38% 0.00% -91.39%
==========================================
Files 11 1 -10
Lines 325 29 -296
Branches 86 14 -72
==========================================
- Hits 297 0 -297
- Misses 12 29 +17
+ Partials 16 0 -16
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
@oclif/parseruses@oclif/errorsat runtime but doesn't declare it as a dependency, this causes Yarn in PnP mode to reject access to the package. When usingnode_modulesthis causes@oclif/parserto rely on hoisting which is not guaranteed to place it in a location where we can access it.How did you fix it?
Moved
@oclif/errorsfromdevDependenciestodependencies