Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

fix: Allow parsing to anything - #75

Closed
ArlonAntonius wants to merge 3 commits into
oclif:masterfrom
ArlonAntonius:aa/fix-types
Closed

fix: Allow parsing to anything#75
ArlonAntonius wants to merge 3 commits into
oclif:masterfrom
ArlonAntonius:aa/fix-types

Conversation

@ArlonAntonius

Copy link
Copy Markdown

This closes oclif/oclif#337

This simply changes the type to any so people can parse to whatever they see fit.

@salesforce-cla

salesforce-cla Bot commented Apr 8, 2020

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @ArlonAntonius to sign the Salesforce.com Contributor License Agreement.

@codecov

codecov Bot commented Apr 8, 2020

Copy link
Copy Markdown

Codecov Report

Merging #75 into master will decrease coverage by 84.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #75       +/-   ##
==========================================
- Coverage   84.45%   0.00%   -84.46%     
==========================================
  Files          11       1       -10     
  Lines         328      29      -299     
  Branches       91      14       -77     
==========================================
- Hits          277       0      -277     
+ Misses         36      29        -7     
+ Partials       15       0       -15     
Impacted Files Coverage Δ
src/validate.ts 0.00% <0.00%> (-31.43%) ⬇️
src/index.ts
src/screen.ts
src/parse.ts
src/flags.ts
src/errors.ts
src/help.ts
src/list.ts
src/deps.ts
src/util.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73c0c4e...70ccaaa. Read the comment docs.

@ArlonAntonius

Copy link
Copy Markdown
Author

Not completely sure what's happening with the Code Coverage on this PR 😮
Did not expect this to affect that much, looks like a bug to me? The code should still be getting called.

@ArlonAntonius

Copy link
Copy Markdown
Author

With the above 2 commits I try to show that the build and code coverage are actually completely fine. When unchanged, it will still show this massive difference in code coverage for no reason.

@RasPhilCo

RasPhilCo commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

Hey @ArlonAntonius, good catch. On further inspection, I think oclif/command#89 solves the issue as it wasn't using any types. Can you try this locally and see?

@ArlonAntonius

Copy link
Copy Markdown
Author

Hi @RasPhilCo,

Sorry for the delay, had the time to test it out and looks like my editor is happy with that change. Would be lovely if it comes through, this PR can be closed in that case.

@RasPhilCo

Copy link
Copy Markdown
Contributor

Shipped & released!

@RasPhilCo RasPhilCo closed this May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS Bug: Arg Parse references String causing IDE errors

2 participants