refactor: make set_credentials synchronous in InMemoryContextCredentialStore#1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix multiple SonarQube issues across the client auth and transports modules.
Changes
1. Make
set_credentialssynchronous (SonarQube S7503)src/a2a/client/auth/credentials.py— removedasyncfromInMemoryContextCredentialStore.set_credentials(pure dict operations, no I/O)tests/client/test_auth_interceptor.py— removedawaitfrom 4 call sites2. Reduce cognitive complexity in
AuthInterceptor.before(SonarQube S3776)src/a2a/client/auth/interceptor.py— extracted_apply_credential,_ensure_context,_apply_bearer,_apply_api_keyhelper methods to reduce nesting3. Fix transport issues (SonarQube S1763, S112, S3776)
src/a2a/client/transports/base.py— added# noqa: S1763for necessaryyieldin abstract async generatorssrc/a2a/client/transports/jsonrpc.py— replaced genericExceptionwithA2AErrorin_create_jsonrpc_errorreturn typesrc/a2a/client/transports/rest.py— extracted_is_error_infoand_extract_error_infohelpers to reduce cognitive complexity in_parse_rest_error4. Remove redundant exception catch (SonarQube S5713)
src/a2a/client/transports/rest.py— removed redundantjson.JSONDecodeErrorfromexcept(subclass ofValueError)Checklist