19.0 tutorials prway#1358
Draft
prway-odoo wants to merge 15 commits into
Draft
Conversation
Some imports are missing in the manifest causing some warnings and the css doesn't load properly. Fix was fixed in the master branch, backporting it in 19.0 for the onboarding classes that always happen in the lastest stable. task-none Part-of: odoo#1037 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
`json` routes were deprecated to `jsonrpc` in 19.0, let's get rid of the warning to avoid confusion for the newdoos. task-none closes odoo#1037 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
-Add the basic structure for the estate module as part of the Odoo Server Framework 101 training.
Reformat the module manifest to follow the project's coding style and add the standard metadata fields required by the tutorial. This commit does not introduce any functional changes.
Add the standard LGPL-3 license declaration to the module manifest so that the module includes the required licensing information expected by Odoo modules.
Introduce the estate property model as the foundation for managing real estate properties in the module. Register the model so it is loaded during module initialization and can be extended by subsequent features, such as views, security rules, and related models.
|
|
Reformat the Python files to follow the project's coding style and improve readability. This commit does not change the module's behavior.
Apply the project's formatting conventions by removing an unnecessary blank line. No functional changes are introduced.
Define the access rights for the estate property model to allow internal users to manage property records according to the module's security configuration.
Include the security access file in the module manifest to ensure the module's access control rules are applied during installation and module upgrades.
Reformat the model to follow the project's coding style by organizing imports, removing unnecessary whitespace, and improving the readability of the field definitions. This commit does not introduce any functional changes.
Provide a graphical interface for the Estate module so users can manage property records from the Odoo backend. This lays the foundation for interacting with the module through standard Odoo workflows rather than direct database access.
prway-odoo
force-pushed
the
19.0-tutorials-prway
branch
from
July 20, 2026 10:59
cc47e43 to
b24eefb
Compare
Establish relationships between property records and their associated entities to accurately model the Estate domain. This provides the foundation for managing related data through the Odoo ORM and user interface.
bit-odoo
reviewed
Jul 21, 2026
bit-odoo
left a comment
There was a problem hiding this comment.
Hello @prway-odoo
Good Start!
Can you please improve all your commit titles and add the commit message as well?
Also, improve the PR title and description.
And you have left many unneccary empty lines.
Thanks
Comment on lines
+1
to
+2
| from datetime import timedelta | ||
| from odoo import models, fields |
There was a problem hiding this comment.
Please followe the import coding guidelines.
| @@ -0,0 +1,3 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | |||
| ,,,,,,, No newline at end of file | |||
There was a problem hiding this comment.
unneccary diff and should be one empty line at the end of the file.
Comment on lines
+69
to
+72
| <filter | ||
| name="available" | ||
| string="Available" | ||
| domain="['|',('state','=','new'),('state','=','offer_received')]"/> |
Comment on lines
+75
to
+78
| <filter | ||
| name="group_by_postcode" | ||
| string="Postcode" | ||
| context="{'group_by':'postcode'}"/> |
| readonly=True, | ||
| copy=False, | ||
| ) | ||
|
|
| ) | ||
|
|
||
| bedrooms = fields.Integer(default=2) | ||
|
|
| garage = fields.Boolean() | ||
| garden = fields.Boolean() | ||
| garden_area = fields.Integer() | ||
|
|
| <field name="expected_price"/> | ||
| <field name="selling_price"/> | ||
| </group> | ||
|
|
| <field name="state"/> | ||
| </group> | ||
| </group> | ||
|
|
prway-odoo
force-pushed
the
19.0-tutorials-prway
branch
3 times, most recently
from
July 24, 2026 08:43
476f9da to
f8d0221
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.