Skip to content
This repository was archived by the owner on Jan 8, 2021. It is now read-only.

Remove check - #9

Open
jburel wants to merge 1 commit into
ome:masterfrom
jburel:remove-check
Open

jburel wants to merge 1 commit into
ome:masterfrom
jburel:remove-check

Conversation

@jburel

@jburel jburel commented Nov 13, 2018

Copy link
Copy Markdown
Member

Names are dynamically set e.g. devspace_redis_1_779f5d44f807
This means that the check will fail.

@joshmoore

Copy link
Copy Markdown
Member

Previously disableClientsUniqueId was preventing the dynamic names from happening. Has that been lost?

@jburel

jburel commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

in devspace repo:

git grep "disableClientsUniqueId"
docker-compose.yml:            - SLAVE_PARAMS=-labels centos7 -labels ice36 -labels java18 -disableClientsUniqueId
docker-compose.yml:            - SLAVE_PARAMS=-labels centos7 -labels ice36 -labels java18 -disableClientsUniqueId
docker-compose.yml:            - SLAVE_PARAMS= -labels centos7 -labels ice36 -labels java18 -disableClientsUniqueId
docker-compose.yml:            - SLAVE_PARAMS=-labels centos7 -labels java18 -disableClientsUniqueId
docker-compose.yml:            - SLAVE_PARAMS=-labels docker -disableClientsUniqueId -executors ${DOCKER_EXECUTORS}

@joshmoore

Copy link
Copy Markdown
Member

Sorry, I misread. This is asserting docker container names not jenkins names. cc: @manics

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants