Skip to content

Build - #6302

Closed
jburel wants to merge 3 commits into
ome:developfrom
jburel:build
Closed

Build#6302
jburel wants to merge 3 commits into
ome:developfrom
jburel:build

Conversation

@jburel

@jburel jburel commented Jan 29, 2022

Copy link
Copy Markdown
Member

This PR

  • Adds dependencies to fix fresh build failure. The problem only occurs when running build-dev
  • Removes zeroc resolver. Breaks the build
  • Removes target no longer required following the split. Breaks the build

@jburel jburel changed the title test Build Jan 31, 2022
This was referenced Jan 31, 2022
@jburel jburel closed this Feb 4, 2022
@jburel jburel reopened this Feb 4, 2022
@sbesson

sbesson commented Feb 17, 2022

Copy link
Copy Markdown
Member

Looking at the downloads for OMERO 5.6.3, the OMERO.apidocs artifact is effectively missing all content. I agree this target does not make sense anymore (probably since OMERO 5.6.0) and removing it from this build is probably the most sensible option. MOving forward I assume:

  • some of the release workflow might need to be adjusted e.g. to skip the unpacking of under https://downloads.openmicroscopy.org/omero/5.6.3/api/python/
  • I assume the generation of this reference API documentation should happen in OMERO.py moving forward. Should this be captured as an issue (or is there already onyl?)

Same thoughts regarding the removal of the ZeroC Nexus. Given this resource is no longer available, it is primarily a source of noise and warnings and it's a good idea to remove the dependency assuming the relevant dependency are all available in secondary repositories.

In which part of the code are the jcommander and joda-time dependencies used? I assume they were previously pulled transitively so do we know what changed and caused these new failures?

@jburel

jburel commented Feb 17, 2022

Copy link
Copy Markdown
Member Author
  • zeroc. On a fresh infra it is more than a warning, it does not build at all
  • for the 2 dependencies, older version are used but the jars do not get downloaded. I investigated the dependencies tree in some repositories but I have not been able to find the exact source of the failure
  • For the docs. Yes adjustments to be made. I have not created an issue regarding the omero-py api

This was referenced Feb 21, 2022
@jburel

jburel commented Feb 21, 2022

Copy link
Copy Markdown
Member Author

Replaced by #6305 and #6306

@jburel jburel closed this Feb 21, 2022
@jburel
jburel deleted the build branch March 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants