ci: bump actions off the deprecated Node 20 runtime - #397
Merged
Conversation
actions/setup-node v4 -> v7: v5+ targets node24; v7 also drops the dummy NODE_AUTH_TOKEN placeholder and documents OIDC trusted publishing. The v5 auto-caching breaking change is inert here (no packageManager field in any package.json). ilammy/msvc-dev-cmd stays at v1 with a KNOWN ANNOTATION comment: no node24 release exists (latest v1.13.0 and master both declare node20; upstream #99/#105 track it). GitHub forces it onto node24, where the v3.4.25 release run shows it works. Audited ci.yml and scheduler-schema.yml too: checkout@v6, rust-cache@v2, upload/download-artifact@v7/v8 are node24; dtolnay/rust-toolchain and taiki-e/install-action are composite. No other node20 actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v3.4.25 release run (33137638534) emitted two "Node.js 20 is deprecated" annotations, on Build aarch64-pc-windows-msvc and Publish npm wrapper. Per the annotations, the offending actions are exactly
ilammy/msvc-dev-cmd@v1andactions/setup-node@v4— nothing else.What
actions/setup-nodev4 → v7 (Publish npm wrapper). v5+ runs on node24; v7 additionally removed the dummyNODE_AUTH_TOKENplaceholder export (actions/setup-node#1558) — the very placeholder our workflow comment blames for npm 10's silent OIDC fallback — and documents npm Trusted Publishing. Breaking changes checked:packageManagerfield inpackage.json— no file in this repo has one, so it's inert (a comment notes this at the pin).node-version: '20'(the Node the job installs, unrelated to the action's runtime) and the npm@11 pin are deliberately untouched.ilammy/msvc-dev-cmdstays at v1, now with a KNOWN ANNOTATION comment. There is no node24 release to bump to: latest tag v1.13.0 and master both declarenode20; upstream tracks it in ilammy/msvc-dev-cmd#99 / #105. GitHub force-runs it on node24, where the v3.4.25 run shows it works — so the annotation on the Windows ARM64 build persists until upstream ships, and the comment says to re-pin then. Swapping to a different MSVC-env action was deliberately avoided: the amd64_arm64 cross environment took 8 documented release attempts to stabilize (see the comments in that job).Audit scope
All pins across
release.yml,ci.yml,scheduler-schema.ymlwere checked against each action'saction.ymlat the pinned ref:actions/setup-node@v4ilammy/msvc-dev-cmd@v1actions/checkout@v6actions/upload-artifact@v7,download-artifact@v7/v8Swatinem/rust-cache@v2dtolnay/rust-toolchain@stable,taiki-e/install-actionLatest ci.yml run has zero annotations, matching the audit. CI-only change — no CHANGELOG entry per convention.
🤖 Generated with Claude Code