feat: extend upload-firmware with timeout/monitoring/label arguments - #80
Merged
Conversation
Contributor
Author
|
Extends #79 |
qkaiser
approved these changes
Aug 26, 2026
qkaiser
left a comment
Contributor
There was a problem hiding this comment.
LGTM even tho I would maybe split each flag into its own commit
kissgyorgy
reviewed
Aug 26, 2026
kissgyorgy
reviewed
Aug 26, 2026
kissgyorgy
reviewed
Aug 26, 2026
kissgyorgy
approved these changes
Aug 26, 2026
This way upload timeout, firmware monitoring and labels can be specified on the command line: upload-firmware --label a --label b --timeout 100 --monitoring ...
martonilles
force-pushed
the
upload-firmware-options
branch
from
August 26, 2026 17:22
5ba433d to
6128f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way upload timeout, firmware monitoring and labels can be specified on the command line:
upload-firmware --label a --label b --timeout 100 --monitoring ...
#74 #76 #77