Skip to content

Fix publish workflow - #84

Merged
qkaiser merged 1 commit into
masterfrom
publish-workflow-fixes
Sep 10, 2026
Merged

Fix publish workflow#84
qkaiser merged 1 commit into
masterfrom
publish-workflow-fixes

Conversation

@vlaci

@vlaci vlaci commented Sep 10, 2026

Copy link
Copy Markdown
Contributor
  • created event does not fire if release is drafted, then undrafted, but published does
  • Unrolled the ternary to conditional steps, as evaluation is confusing there.

László Vaskó
Fix publish workflow
b7b966f 
- `created` event does not fire if release is drafted, then undrafted,
  but published does
- Unrolled the ternary to conditional steps, as evaluation is
  confusing there.
@qkaiser
qkaiser self-requested a review September 10, 2026 09:21
@qkaiser qkaiser added the bug Something isn't working label Sep 10, 2026
qkaiser
qkaiser reviewed Sep 10, 2026
View reviewed changes

@qkaiser qkaiser left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coding agent differential review:

The revised trigger handles publishing previously drafted releases, and the conditional steps correctly route manual test releases to TestPyPI while routing production dispatches and release events to PyPI.

@qkaiser
qkaiser added this pull request to the merge queue Sep 10, 2026
Merged via the queue into master with commit 65f5e26 Sep 10, 2026
2 checks passed
@qkaiser
qkaiser deleted the publish-workflow-fixes branch September 10, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qkaiser qkaiser qkaiser approved these changes

Assignees

@vlaci vlaci

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlaci @qkaiser