Match a display:none style case-insensitively, as CSS does - #124
Merged
Merged
Conversation
CSS property names and keywords are case-insensitive and may have space before the colon, but the hidden check only matched lowercase "display:none". Content styled DISPLAY:NONE, Display: None or display : none leaked into the view and into raw. Both paths now share one case-insensitive pattern. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #123, which noted that an uppercase style value still got through.
CSS property names and keywords are case-insensitive, and a space before the colon is valid. The hidden check only matched lowercase
display:none, so content styledDISPLAY:NONE,Display: Noneordisplay : noneleaked into the view and into raw.Both checks (the
hiddentest indistill()and the sweep incleanDocument()) now share one pattern,/display\s*:\s*none/i.Verification:
tests/distill.test.jscovering all three spellings in the view,toMarkdownandtoHTML. It fails without the change (secret-upper leaked) and passes with it.npm test: 322/322 pass.🤖 Generated with Claude Code