fix(echcheck): do not attempt a TLS handshake when the TCP connect failed

internal/experiment/echcheck/handshake.go

@@ -69,6 +69,9 @@ func handshake(ctx context.Context, isGrease bool, startTime time.Time, address
 	ol1.Stop(err)
 	tk.TCPConnects = append(tk.TCPConnects, trace.TCPConnects()...)
 	tk.NetworkEvents = append(tk.NetworkEvents, trace.NetworkEvents()...)
+	if err != nil {
+		return tk
+	}
 
 	ol2 := logx.NewOperationLogger(logger, "echcheck: DialTLS%s", d)
 	start := time.Now()

internal/experiment/echcheck/handshake_test.go

@@ -6,6 +6,7 @@ import (
 	"crypto/tls"
 	"crypto/x509"
 	"fmt"
+	"net"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
@@ -158,3 +159,40 @@ func TestHandshake(t *testing.T) {
 		})
 	}
 }
+
+func TestHandshakeTCPConnectFailure(t *testing.T) {
+	l, err := net.Listen("tcp", "127.0.0.1:0")
+	if err != nil {
+		t.Fatal(err)
+	}
+	address := l.Addr().String()
+	l.Close()
+
+	parsed := &url.URL{Scheme: "https", Host: address}
+	for _, sendGrease := range []bool{false, true} {
+		t.Run(fmt.Sprintf("grease=%v", sendGrease), func(t *testing.T) {
+			ecl := []byte{}
+			if sendGrease {
+				grease, err := generateGreaseyECHConfigList(rand.Reader, parsed.Hostname())
+				if err != nil {
+					t.Fatal(err)
+				}
+				ecl = grease
+			}
+			ch, err := startHandshake(context.Background(), ecl, sendGrease, time.Now(), address, parsed, model.DiscardLogger, nil)
+			if err != nil {
+				t.Fatal(err)
+			}
+			result := <-ch
+			if len(result.TCPConnects) != 1 {
+				t.Fatal("expected exactly one TCPConnect, got: ", len(result.TCPConnects))
+			}
+			if result.TCPConnects[0].Status.Failure == nil {
+				t.Fatal("expected the TCPConnect to carry a failure")
+			}
+			if len(result.TLSHandshakes) != 0 {
+				t.Fatal("expected no TLS handshake without a connection, got: ", len(result.TLSHandshakes))
+			}
+		})
+	}
+}

internal/experiment/echcheck/measure.go

@@ -18,7 +18,7 @@ import (
 
 const (
 	testName    = "echcheck"
-	testVersion = "0.3.1"
+	testVersion = "0.3.2"
 	defaultURL  = "https://cloudflare-ech.com/cdn-cgi/trace"
 )
 

internal/experiment/echcheck/measure_test.go

@@ -16,7 +16,7 @@ func TestNewExperimentMeasurer(t *testing.T) {
 	if measurer.ExperimentName() != "echcheck" {
 		t.Fatal("unexpected name")
 	}
-	if measurer.ExperimentVersion() != "0.3.1" {
+	if measurer.ExperimentVersion() != "0.3.2" {
 		t.Fatal("unexpected version")
 	}
 }