Skip to content

Remove type from the resource. - #145

Merged
bogdandrutu merged 2 commits into
masterfrom
resourcetype
Apr 17, 2019
Merged

Remove type from the resource.#145
bogdandrutu merged 2 commits into
masterfrom
resourcetype

Conversation

@bogdandrutu

Copy link
Copy Markdown
Member

No description provided.

string type = 1;

// Set of labels that describe the resource.
map<string,string> labels = 2;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 1 now?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rochdev

rochdev commented Jun 21, 2019

Copy link
Copy Markdown
Member

@bogdandrutu What was the reasoning behind the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants