fix: keep non-gRPC transports optional - #739
Open
simonyang08 wants to merge 1 commit into
Open
simonyang08 wants to merge 1 commit into
simonyang08 wants to merge 1 commit into
Conversation
|
@ppt5928-dot is attempting to deploy a commit to the Raphael's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmits #647 per the invitation in #647 (comment) — fresh, non-draft, and rebased onto current develop (
81289018). The original analysis and approach are unchanged; thanks @zomux for confirming the problem is still live.Problem
grpciois only an optional extra inpyproject.toml, yetsdk/openagents/sdk/transports/__init__.pyimported the gRPC transport eagerly, so none of the transports were importable withoutgrpcioinstalled — including the HTTP transport that has no gRPC dependency at all.Still reproducible on current develop (verified today): with
grpcblocked from the import system,from openagents.sdk.transports import HttpTransportraisesFix (lazy exports)
transports/__init__.pyno longer imports the gRPC module up front; it exposesGRPCTransportvia a module-level__getattr__that only imports.grpcwhen the name is actually accessed, raising the same actionable error ifgrpciois missing.topology.pyimports.transports.grpcsymbols directly where they are used, so it does not force the lazy export machinery.Verification
tests/test_optional_grpc.py: withgrpcblocked,HttpTransport(and friends) import cleanly,grpcnever lands insys.modules, and accessingGRPCTransportraises the actionable install hint. 1 passed on this branch; on pure develop the same import raises (RED confirmed today).81289018; no other files touched (topology.py,transports/__init__.py, one new test).