fix(auth): preserve IPv6 verification URL brackets - #232
Open
dipeshbabu wants to merge 1 commit into
Open
Conversation
Collaborator
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
dipeshbabu
force-pushed
the
agent/preserve-ipv6-auth-url-bracket
branch
from
August 4, 2026 05:58
74e6b9e to
e18f3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The authentication URL extractor treated every trailing
]as punctuation. For a valid URL such ashttps://[2001:db8::1], that character is structural, so removing it made URL parsing fail and caused the login instructions to omit the verification URL.Impact
Interactive device login now retains valid external IPv6 verification URLs while continuing to reject local addresses and strip surrounding prose punctuation.
Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/auth.test.ts(17 passed, 1 skipped)pnpm exec tsc --noEmitpnpm exec prettier --check src/auth.ts tests-ts/auth.test.tsgit diff --check