Skip to content

Enable --deny-warnings for cargo shear #21616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliemarsh-oai merged 6 commits into from
May 8, 2026
Merged

Enable --deny-warnings for cargo shear #21616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce52737
Enforce cargo-shear warnings
charliemarsh-oai May 7, 2026
8ea71d1
Avoid cargo-shear ignores
charliemarsh-oai May 8, 2026
9307e77
Preserve wrapper
charliemarsh-oai May 8, 2026
a324832
Remove duplicate Windows cfg attributes
charliemarsh-oai May 8, 2026
b347e68
Duplicate small helper
charliemarsh-oai May 8, 2026
69a77a2
Refresh lockfiles
charliemarsh-oai May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/rust-ci-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ jobs:
- uses: dtolnay/rust-toolchain@a0b273b48ed29de4470960879e8381ff45632f26 # 1.93.0
- uses: taiki-e/install-action@44c6d64aa62cd779e873306675c7a58e86d6d532 # v2.62.49
with:
tool: cargo-shear
version: 1.11.2
tool: cargo-shear@1.11.2

@charliemarsh-oai charliemarsh-oai May 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an oversight from a prior PR (i.e., using the wrong format here).

- name: cargo shear
run: cargo shear
run: cargo shear --deny-warnings

argument_comment_lint_package:
name: Argument comment lint package
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/rust-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,9 @@ jobs:
- uses: dtolnay/rust-toolchain@a0b273b48ed29de4470960879e8381ff45632f26 # 1.93.0
- uses: taiki-e/install-action@44c6d64aa62cd779e873306675c7a58e86d6d532 # v2.62.49
with:
tool: cargo-shear
version: 1.11.2
tool: cargo-shear@1.11.2
- name: cargo shear
run: cargo shear
run: cargo shear --deny-warnings

argument_comment_lint_package:
name: Argument comment lint package
Expand Down
1 change: 0 additions & 1 deletion codex-rs/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions codex-rs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,11 +464,8 @@ unwrap_used = "deny"
[workspace.metadata.cargo-shear]
ignored = [
"codex-agent-graph-store",
"codex-memories-mcp",
"icu_provider",
"openssl-sys",
"codex-utils-readiness",
"codex-utils-template",
"codex-v8-poc",
]

Expand Down
3 changes: 0 additions & 3 deletions codex-rs/codex-backend-openapi-models/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,3 @@ workspace = true
serde = { version = "1", features = ["derive"] }
serde_json = "1"
serde_with = "3"

[package.metadata.cargo-shear]
ignored = ["serde_with"]
41 changes: 0 additions & 41 deletions codex-rs/core/src/tools/code_mode/execute_handler_tests.rs
View file
Open in desktop

This file was deleted.

95 changes: 0 additions & 95 deletions codex-rs/core/src/tools/handlers/grep_files_tests.rs
View file
Open in desktop

This file was deleted.

Loading
Loading