Detect Codex installs managed by Vite+ - #30880
Draft
charliemarsh-oai wants to merge 1 commit into
Draft
charliemarsh-oai wants to merge 1 commit into
charliemarsh-oai wants to merge 1 commit into
Conversation
This was referenced Jul 2, 2026
charliemarsh-oai
marked this pull request as ready for review
July 6, 2026 11:53
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc174cdc4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| match self { | ||
| UpdateAction::NpmGlobalLatest => ("npm", &["install", "-g", "@openai/codex"]), | ||
| UpdateAction::BunGlobalLatest => ("bun", &["install", "-g", "@openai/codex"]), | ||
| UpdateAction::VitePlusGlobalLatest => ("vp", &["install", "-g", "@openai/codex"]), |
Contributor
There was a problem hiding this comment.
When the install context is VitePlus, this new action renders as the command in the update popup/history via UpdateAction::command_str(), but the change only adds a mapping unit test and leaves the existing insta snapshots covering other install paths. That means the new Vite+ update UI text can regress without the visual review/CI coverage required for TUI-visible changes.
Useful? React with 👍 / 👎.
charliemarsh-oai
marked this pull request as draft
July 8, 2026 00:37
copyberry Bot
pushed a commit
that referenced
this pull request
Sep 1, 2026
## Why Vite+ launches Codex through the same JavaScript shim as npm, so Codex could misidentify Vite+-owned installations and recommend npm for updates. ## What changed - Detect Vite+ global installs from their package ownership metadata and pass a dedicated `CODEX_MANAGED_BY_VITE_PLUS` marker to the native binary. - Represent Vite+ in install context and `codex doctor` output. - Recommend `vp install -g @openai/codex` in update and repair flows for Vite+-managed installs. See #30880. GitOrigin-RevId: 8add724eefd31170a078086392609dbbd7f20b26
boboZeng
pushed a commit
to boboZeng/codex
that referenced
this pull request
Sep 14, 2026
## Why Vite+ launches Codex through the same JavaScript shim as npm, so Codex could misidentify Vite+-owned installations and recommend npm for updates. ## What changed - Detect Vite+ global installs from their package ownership metadata and pass a dedicated `CODEX_MANAGED_BY_VITE_PLUS` marker to the native binary. - Represent Vite+ in install context and `codex doctor` output. - Recommend `vp install -g @openai/codex` in update and repair flows for Vite+-managed installs. See openai#30880. GitOrigin-RevId: 8add724eefd31170a078086392609dbbd7f20b26
sedna-release-publisher Bot
pushed a commit
to sednalabs/codex
that referenced
this pull request
Sep 15, 2026
## Why Vite+ launches Codex through the same JavaScript shim as npm, so Codex could misidentify Vite+-owned installations and recommend npm for updates. ## What changed - Detect Vite+ global installs from their package ownership metadata and pass a dedicated `CODEX_MANAGED_BY_VITE_PLUS` marker to the native binary. - Represent Vite+ in install context and `codex doctor` output. - Recommend `vp install -g @openai/codex` in update and repair flows for Vite+-managed installs. See openai#30880. GitOrigin-RevId: 8add724eefd31170a078086392609dbbd7f20b26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp install -g @openai/codexwhen repairing or updating Vite+-managed installsWhy
Vite+ installs
@openai/codexunderVP_HOME/packagesbut launches through the same JavaScript shim as npm. The shim previously treated any non-Bun launch as npm-managed, so doctor and update flows suggested npm even though Vite+ owned the package. A dedicated marker keeps ownership accurate and clears stale package-manager markers before launching the native binary.Focused install-context and update-action coverage passes, including a smoke test using the Vite+ directory layout. Scoped Clippy, formatting, and diff checks pass. The broader affected-crate run passed 3,260 tests; two unrelated Guardian tests failed identically on
main.Closes #30698.