Terminate Windows non-TTY processes on interrupt - #35655
Merged
copyberry[bot] merged 1 commit intoJul 27, 2026
Merged
Conversation
## Why Windows non-TTY exec sessions reported interrupts as unsupported, so sending Ctrl-C through `write_stdin` did not stop the running process. ## What changed - Route interrupt requests for Windows non-TTY processes through their existing termination callback, including pipe-backed processes. - Track whether driver-backed Windows sessions use a TTY so PTY interrupts keep their existing behavior. - Consume the terminator after a successful interrupt to avoid invoking it again when the process handle is dropped. ## Testing Added coverage for local and remote exec-server sessions, unified exec, pipe fallbacks, and legacy Windows sandbox processes. GitOrigin-RevId: 34504d01f091ef57bb961e98ad5a8d9f1acee4ee
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/34504d01f091ef57bb961e98ad5a8d9f1acee4ee
branch
from
July 27, 2026 18:37
fdfaa25 to
6b23635
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/34504d01f091ef57bb961e98ad5a8d9f1acee4ee
branch
July 27, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminate Windows non-TTY processes on interrupt
Why
Windows non-TTY exec sessions reported interrupts as unsupported, so sending
Ctrl-C through
write_stdindid not stop the running process.What changed
termination callback, including pipe-backed processes.
their existing behavior.
when the process handle is dropped.
Testing
Added coverage for local and remote exec-server sessions, unified exec, pipe
fallbacks, and legacy Windows sandbox processes.