Skip to content

Preserve hyperlink cell widths during terminal diffing - #35960

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/041128f43beb1e09d40179a3ac16dca1fbdcbc44
Jul 29, 2026
Merged

Preserve hyperlink cell widths during terminal diffing#35960
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/041128f43beb1e09d40179a3ac16dca1fbdcbc44

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 29, 2026

Copy link
Copy Markdown

Preserve hyperlink cell widths during terminal diffing

What changed

  • Mark OSC 8 hyperlink cells with their visible width so Ratatui's buffer diff handles wide and halfwidth characters correctly.
  • Use Ratatui's diff iterator while explicitly clearing styled trailing cells when a forced-width cell replaces a wider cell.

Testing

  • Add coverage for forced-width hyperlink rendering, always-update cells, and styled trailing-cell cleanup.

## What changed

- Mark OSC 8 hyperlink cells with their visible width so Ratatui's buffer diff handles wide and halfwidth characters correctly.
- Use Ratatui's diff iterator while explicitly clearing styled trailing cells when a forced-width cell replaces a wider cell.

## Testing

- Add coverage for forced-width hyperlink rendering, always-update cells, and styled trailing-cell cleanup.

GitOrigin-RevId: 041128f43beb1e09d40179a3ac16dca1fbdcbc44
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/041128f43beb1e09d40179a3ac16dca1fbdcbc44 branch from 72550a9 to cef3910 Compare July 29, 2026 13:58
@copyberry
copyberry Bot merged commit cef3910 into main Jul 29, 2026
29 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/041128f43beb1e09d40179a3ac16dca1fbdcbc44 branch July 29, 2026 14:00
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2026
@r3v5
r3v5 temporarily deployed to issue-triage July 29, 2026 14:00 — with GitHub Actions Inactive
@r3v5
r3v5 temporarily deployed to issue-triage July 29, 2026 14:00 — with GitHub Actions Inactive
@r3v5
r3v5 temporarily deployed to issue-triage July 29, 2026 14:00 — with GitHub Actions Inactive
@r3v5
r3v5 temporarily deployed to issue-triage July 29, 2026 14:01 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants