Retain the MCP client for event streams - #41892
Merged
copyberry[bot] merged 1 commit intoAug 31, 2026
Merged
Conversation
## What changed - Add `McpEventStream::open` to construct event stream requests and keep the underlying `RmcpClient` alive until the subscription completes or is canceled. - Stop retaining the broader `McpServerConnection` for the lifetime of an event stream, and remove the connection-returning lookup helper. - Use MCP event server terminology in event discovery and subscription errors. GitOrigin-RevId: 7d6c7b8ed9c5447d2d8cda4a077da845fb026173
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/7d6c7b8ed9c5447d2d8cda4a077da845fb026173
branch
from
August 31, 2026 18:24
a9328d0 to
e51b54b
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/7d6c7b8ed9c5447d2d8cda4a077da845fb026173
branch
August 31, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain the MCP client for event streams
What changed
McpEventStream::opento construct event stream requests and keep theunderlying
RmcpClientalive until the subscription completes or is canceled.McpServerConnectionfor the lifetime of an eventstream, and remove the connection-returning lookup helper.