Skip to content

Fix Windows native voice dependency builds - #41894

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f
Aug 31, 2026
Merged

Fix Windows native voice dependency builds#41894
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 31, 2026

Copy link
Copy Markdown

Fix Windows native voice dependency builds

Why

Windows builds combine Cygwin build tools with native MSVC outputs. On ARM64,
Cygwin can run under x64 emulation, so inferred host details and untranslated
paths can select the wrong target or leak POSIX paths into native metadata.

What changed

  • Convert libffi source, prefix, and shell paths with cygpath, preserve
    USERPROFILE, and pass explicit build and host targets.
  • Configure libffi's MSVC and libtool environment to produce and install its
    shared library and import library, including across recursive make calls.
  • Reject libffi pkg-config output containing /cygdrive/ paths and enable
    Opus NEON support for aarch64-pc-windows-msvc.
  • Document the additional Windows build prerequisites.

Testing

  • Extend test_build_native.py with Windows path conversion, x64 and ARM64
    target configuration, recursive make flag propagation, pkg-config, and Opus
    coverage.

@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

copyberry Bot pushed a commit that referenced this pull request Aug 31, 2026
## Why

Windows builds combine Cygwin build tools with native MSVC outputs. On ARM64,
Cygwin can run under x64 emulation, so inferred host details and untranslated
paths can select the wrong target or leak POSIX paths into native metadata.

## What changed

- Convert libffi source, prefix, and shell paths with `cygpath`, preserve
  `USERPROFILE`, and pass explicit build and host targets.
- Configure libffi's MSVC and libtool environment to produce and install its
  shared library and import library, including across recursive make calls.
- Reject libffi pkg-config output containing `/cygdrive/` paths and enable
  Opus NEON support for `aarch64-pc-windows-msvc`.
- Document the additional Windows build prerequisites.

## Testing

- Extend `test_build_native.py` with Windows path conversion, x64 and ARM64
  target configuration, recursive make flag propagation, pkg-config, and Opus
  coverage.

GitOrigin-RevId: 12eb4ff83e141aa069abd68af4839f06e4c45b8f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f branch from c2f6b9e to c62dffa Compare August 31, 2026 19:01
## Why

Windows builds combine Cygwin build tools with native MSVC outputs. On ARM64,
Cygwin can run under x64 emulation, so inferred host details and untranslated
paths can select the wrong target or leak POSIX paths into native metadata.

## What changed

- Convert libffi source, prefix, and shell paths with `cygpath`, preserve
  `USERPROFILE`, and pass explicit build and host targets.
- Configure libffi's MSVC and libtool environment to produce and install its
  shared library and import library, including across recursive make calls.
- Reject libffi pkg-config output containing `/cygdrive/` paths and enable
  Opus NEON support for `aarch64-pc-windows-msvc`.
- Document the additional Windows build prerequisites.

## Testing

- Extend `test_build_native.py` with Windows path conversion, x64 and ARM64
  target configuration, recursive make flag propagation, pkg-config, and Opus
  coverage.

GitOrigin-RevId: 12eb4ff83e141aa069abd68af4839f06e4c45b8f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f branch 2 times, most recently from 6cca925 to 65237ae Compare August 31, 2026 19:02
@copyberry
copyberry Bot merged commit 65237ae into main Aug 31, 2026
18 of 24 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f branch August 31, 2026 19:03
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants