Fix Windows native voice dependency builds - #41894
Merged
copyberry[bot] merged 1 commit intoAug 31, 2026
Merged
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
## Why Windows builds combine Cygwin build tools with native MSVC outputs. On ARM64, Cygwin can run under x64 emulation, so inferred host details and untranslated paths can select the wrong target or leak POSIX paths into native metadata. ## What changed - Convert libffi source, prefix, and shell paths with `cygpath`, preserve `USERPROFILE`, and pass explicit build and host targets. - Configure libffi's MSVC and libtool environment to produce and install its shared library and import library, including across recursive make calls. - Reject libffi pkg-config output containing `/cygdrive/` paths and enable Opus NEON support for `aarch64-pc-windows-msvc`. - Document the additional Windows build prerequisites. ## Testing - Extend `test_build_native.py` with Windows path conversion, x64 and ARM64 target configuration, recursive make flag propagation, pkg-config, and Opus coverage. GitOrigin-RevId: 12eb4ff83e141aa069abd68af4839f06e4c45b8f
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f
branch
from
August 31, 2026 19:01
c2f6b9e to
c62dffa
Compare
## Why Windows builds combine Cygwin build tools with native MSVC outputs. On ARM64, Cygwin can run under x64 emulation, so inferred host details and untranslated paths can select the wrong target or leak POSIX paths into native metadata. ## What changed - Convert libffi source, prefix, and shell paths with `cygpath`, preserve `USERPROFILE`, and pass explicit build and host targets. - Configure libffi's MSVC and libtool environment to produce and install its shared library and import library, including across recursive make calls. - Reject libffi pkg-config output containing `/cygdrive/` paths and enable Opus NEON support for `aarch64-pc-windows-msvc`. - Document the additional Windows build prerequisites. ## Testing - Extend `test_build_native.py` with Windows path conversion, x64 and ARM64 target configuration, recursive make flag propagation, pkg-config, and Opus coverage. GitOrigin-RevId: 12eb4ff83e141aa069abd68af4839f06e4c45b8f
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f
branch
2 times, most recently
from
August 31, 2026 19:02
6cca925 to
65237ae
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/12eb4ff83e141aa069abd68af4839f06e4c45b8f
branch
August 31, 2026 19:03
khurshhh1999
temporarily deployed
to
issue-triage
August 31, 2026 19:04 — with
GitHub Actions
Inactive
khurshhh1999
temporarily deployed
to
issue-triage
August 31, 2026 19:04 — with
GitHub Actions
Inactive
khurshhh1999
temporarily deployed
to
issue-triage
August 31, 2026 19:04 — with
GitHub Actions
Inactive
DRanger666
temporarily deployed
to
issue-triage
August 31, 2026 19:04 — with
GitHub Actions
Inactive
DRanger666
temporarily deployed
to
issue-triage
August 31, 2026 19:04 — with
GitHub Actions
Inactive
DRanger666
temporarily deployed
to
issue-triage
August 31, 2026 19:04 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows native voice dependency builds
Why
Windows builds combine Cygwin build tools with native MSVC outputs. On ARM64,
Cygwin can run under x64 emulation, so inferred host details and untranslated
paths can select the wrong target or leak POSIX paths into native metadata.
What changed
cygpath, preserveUSERPROFILE, and pass explicit build and host targets.shared library and import library, including across recursive make calls.
/cygdrive/paths and enableOpus NEON support for
aarch64-pc-windows-msvc.Testing
test_build_native.pywith Windows path conversion, x64 and ARM64target configuration, recursive make flag propagation, pkg-config, and Opus
coverage.