Skip to content

Add a manager for MCP event streams - #41906

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/b7156bbe62f9375b2138eb62868f052124e2a884
Aug 31, 2026
Merged

Add a manager for MCP event streams#41906
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/b7156bbe62f9375b2138eb62868f052124e2a884

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 31, 2026

Copy link
Copy Markdown

Add a manager for MCP event streams

What changed

  • Add McpEventStreamManager to own event stream workers by thread and subscription.
  • Wait for activation before completing a start, tag updates with a stream attempt ID, and keep active streams alive independently of their originating runtime.
  • Support cancellation and shutdown without depending on output queue capacity, and close streams when MCP access changes or an event server is removed.
  • Reconnect reloaded threads to surviving streams so server removal still cancels them.

Testing

Add coverage for activation, replacement attempts, task reloads, cancellation before activation, full output queues, access changes, and shutdown.

## What changed

- Add `McpEventStreamManager` to own event stream workers by thread and subscription.
- Wait for activation before completing a start, tag updates with a stream attempt ID, and keep active streams alive independently of their originating runtime.
- Support cancellation and shutdown without depending on output queue capacity, and close streams when MCP access changes or an event server is removed.
- Reconnect reloaded threads to surviving streams so server removal still cancels them.

## Testing

Add coverage for activation, replacement attempts, task reloads, cancellation before activation, full output queues, access changes, and shutdown.

GitOrigin-RevId: b7156bbe62f9375b2138eb62868f052124e2a884
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/b7156bbe62f9375b2138eb62868f052124e2a884 branch from 91e51dc to ae0ecd7 Compare August 31, 2026 20:32
@copyberry
copyberry Bot merged commit ae0ecd7 into main Aug 31, 2026
24 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/b7156bbe62f9375b2138eb62868f052124e2a884 branch August 31, 2026 20:33
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants