Skip to content

Preserve TUI status timing when the status row is hidden - #41913

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a77931e465d5aedd4a8cd606a3a3117d1bb37ce7
Aug 31, 2026
Merged

Preserve TUI status timing when the status row is hidden#41913
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a77931e465d5aedd4a8cd606a3a3117d1bb37ce7

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 31, 2026

Copy link
Copy Markdown

Preserve TUI status timing when the status row is hidden

Why

Streaming can temporarily hide the status row, but its elapsed time is still
needed when the row returns and when the final Worked for duration falls back
to the local clock. Approval prompts must also keep that clock paused.

What changed

  • Own the pause-aware status timer in the bottom pane independently of the
    optional status row.
  • Preserve elapsed time and modal pause state while hiding or restoring the row,
    and reset the clock for new turns and Windows sandbox setup.
  • Use the independent timer as the fallback for the final turn duration.

Testing

Add timer unit coverage and TUI tests for hidden rows, outstanding approvals,
fallback turn durations, and fresh Windows sandbox setup clocks.

## Why

Streaming can temporarily hide the status row, but its elapsed time is still
needed when the row returns and when the final `Worked for` duration falls back
to the local clock. Approval prompts must also keep that clock paused.

## What changed

- Own the pause-aware status timer in the bottom pane independently of the
  optional status row.
- Preserve elapsed time and modal pause state while hiding or restoring the row,
  and reset the clock for new turns and Windows sandbox setup.
- Use the independent timer as the fallback for the final turn duration.

## Testing

Add timer unit coverage and TUI tests for hidden rows, outstanding approvals,
fallback turn durations, and fresh Windows sandbox setup clocks.

GitOrigin-RevId: a77931e465d5aedd4a8cd606a3a3117d1bb37ce7
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/a77931e465d5aedd4a8cd606a3a3117d1bb37ce7 branch from 1dda238 to 17e8101 Compare August 31, 2026 21:20
@copyberry
copyberry Bot merged commit 17e8101 into main Aug 31, 2026
24 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/a77931e465d5aedd4a8cd606a3a3117d1bb37ce7 branch August 31, 2026 21:21
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants