Use executor path context for permission preapproval - #41928
Merged
copyberry[bot] merged 1 commit intoAug 31, 2026
Merged
Conversation
## Why Permission grants can belong to an executor whose path convention differs from the local host, such as a Windows remote environment. Matching those grants against a host-native working directory can reject valid permissions. ## What changed - Normalize, materialize, and compare additional filesystem permissions using the selected executor's URI-based sandbox context. - Apply the same context-aware preapproval flow to `exec_command`, `apply_patch`, and extension tools. - Fail closed when symbolic temporary-directory or project-root permissions cannot be resolved from executor metadata, while accepting opaque working directory URIs when requested paths use the executor's convention. ## Testing - Added coverage for reusing a Windows permission grant from a non-Windows host, resolving symbolic temporary-directory grants, and normalizing paths with an opaque Windows working directory. GitOrigin-RevId: aee54350a25430a0443f8319e2bb0bbdc4f44282
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/aee54350a25430a0443f8319e2bb0bbdc4f44282
branch
from
August 31, 2026 22:59
dcee940 to
c4350b4
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/aee54350a25430a0443f8319e2bb0bbdc4f44282
branch
August 31, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use executor path context for permission preapproval
Why
Permission grants can belong to an executor whose path convention differs from
the local host, such as a Windows remote environment. Matching those grants
against a host-native working directory can reject valid permissions.
What changed
the selected executor's URI-based sandbox context.
exec_command,apply_patch, and extension tools.cannot be resolved from executor metadata, while accepting opaque working
directory URIs when requested paths use the executor's convention.
Testing
host, resolving symbolic temporary-directory grants, and normalizing paths
with an opaque Windows working directory.