Skip to content

Attach failed Guardian reviews to diagnostic reports - #41936

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/5f12f7605041c3c84e826e6bac1cf06b1518ab24
Aug 31, 2026
Merged

Attach failed Guardian reviews to diagnostic reports#41936
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/5f12f7605041c3c84e826e6bac1cf06b1518ab24

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 31, 2026

Copy link
Copy Markdown

Attach failed Guardian reviews to diagnostic reports

What changed

  • Retain bounded, process-local records for failed Guardian reviews, including the reviewed action, decision, status, model, instructions, and reviewer history.
  • Add recent records from the reported thread and its descendants to log-enabled report uploads as auto-review-failures.jsonl.
  • Preserve the action and decision while omitting oversized reviewer context, and exclude successful, ephemeral, and capture-disabled reviews.

Testing

  • Cover denied and invalid decisions, cleaned-up ephemeral reviewers, descendant-thread selection, record count and byte limits, and oversized-context fallback.

## What changed

- Retain bounded, process-local records for failed Guardian reviews, including the reviewed action, decision, status, model, instructions, and reviewer history.
- Add recent records from the reported thread and its descendants to log-enabled report uploads as `auto-review-failures.jsonl`.
- Preserve the action and decision while omitting oversized reviewer context, and exclude successful, ephemeral, and capture-disabled reviews.

## Testing

- Cover denied and invalid decisions, cleaned-up ephemeral reviewers, descendant-thread selection, record count and byte limits, and oversized-context fallback.

GitOrigin-RevId: 5f12f7605041c3c84e826e6bac1cf06b1518ab24
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/5f12f7605041c3c84e826e6bac1cf06b1518ab24 branch from 4ad8bfb to 13d75cd Compare August 31, 2026 23:45
@copyberry
copyberry Bot merged commit 13d75cd into main Aug 31, 2026
25 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/5f12f7605041c3c84e826e6bac1cf06b1518ab24 branch August 31, 2026 23:47
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant