Honor explicit account selectors for Apps tool calls - #42054
Merged
copyberry[bot] merged 1 commit intoSep 1, 2026
Merged
Conversation
## What changed - Resolve `link_id` from tool-call arguments when Apps metadata sets `requires_explicit_link_id` to `true`. - Reject the call before approval or execution when the required selector is missing, empty, or not a string. - Preserve catalog-provided account metadata for legacy Apps tools and leave non-Apps MCP tools unchanged. ## Testing - Add unit coverage for required selectors, malformed values, legacy fallbacks, and non-Apps tools. - Add end-to-end coverage for execution, approval prompts, and rejection when an Apps call omits `link_id`. GitOrigin-RevId: 667fd04102a3934d53ded020da6d1bf68a1ca3e5
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/667fd04102a3934d53ded020da6d1bf68a1ca3e5
branch
from
September 1, 2026 13:29
76b458c to
0e37d83
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/667fd04102a3934d53ded020da6d1bf68a1ca3e5
branch
September 1, 2026 13:30
CrazyATE
temporarily deployed
to
issue-triage
September 1, 2026 13:36 — with 
GitHub Actions
Inactive
CrazyATE
temporarily deployed
to
issue-triage
September 1, 2026 13:36 — with
GitHub Actions
Inactive
CrazyATE
temporarily deployed
to
issue-triage
September 1, 2026 13:36 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor explicit account selectors for Apps tool calls
What changed
link_idfrom tool-call arguments when Apps metadata setsrequires_explicit_link_idtotrue.missing, empty, or not a string.
non-Apps MCP tools unchanged.
Testing
fallbacks, and non-Apps tools.
an Apps call omits
link_id.