Skip to content

Attribute nested REPL reviews to their tool calls - #42082

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/adea4b5cff96726a540ff3b3ea902b0f5dd99299
Sep 1, 2026
Merged

Attribute nested REPL reviews to their tool calls#42082
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/adea4b5cff96726a540ff3b3ea902b0f5dd99299

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 1, 2026

Copy link
Copy Markdown

Attribute nested REPL reviews to their tool calls

What changed

  • Retain MCP invocation metadata for Node-backed REPL servers so nested
    elicitations can resolve the enclosing tool call.
  • Use a valid, same-server callId from the current turn as the Guardian
    assessment target while continuing to review each nested action and connector
    independently.
  • Fall back to an elicitation-specific target when callId is missing,
    malformed, unknown, from another server, or from an earlier turn.

Testing

  • Cover ordinary and strict reviews for node_repl and cua_repl, multiple
    nested decisions, unrelated servers, and invalid or stale call IDs.

## What changed

- Retain MCP invocation metadata for Node-backed REPL servers so nested
  elicitations can resolve the enclosing tool call.
- Use a valid, same-server `callId` from the current turn as the Guardian
  assessment target while continuing to review each nested action and connector
  independently.
- Fall back to an elicitation-specific target when `callId` is missing,
  malformed, unknown, from another server, or from an earlier turn.

## Testing

- Cover ordinary and strict reviews for `node_repl` and `cua_repl`, multiple
  nested decisions, unrelated servers, and invalid or stale call IDs.

GitOrigin-RevId: adea4b5cff96726a540ff3b3ea902b0f5dd99299
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/adea4b5cff96726a540ff3b3ea902b0f5dd99299 branch from f0d9a06 to 67cc3c3 Compare September 1, 2026 15:35
@copyberry
copyberry Bot merged commit 67cc3c3 into main Sep 1, 2026
24 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/adea4b5cff96726a540ff3b3ea902b0f5dd99299 branch September 1, 2026 15:36
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants