Skip to content

Make diagnostic report uploads resilient to slow networks - #42096

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/bdacf6c9731df16d2763e204565986eb6d540233
Sep 1, 2026
Merged

Make diagnostic report uploads resilient to slow networks#42096
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/bdacf6c9731df16d2763e204565986eb6d540233

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 1, 2026

Copy link
Copy Markdown

Make diagnostic report uploads resilient to slow networks

Why

Diagnostic reports can span several envelopes, and the previous 10-second shared
network budget could expire before slow uploads and their attachments completed.

What changed

  • Give each diagnostic report a single five-minute deadline shared by the event,
    attachments, retries, and retry backoff.
  • Stop reading or sending later attachments once the deadline or a Sentry rate
    limit is reached.
  • Limit the app server to three concurrent report uploads and return an
    overloaded JSON-RPC error for additional requests until a slot is released.

Testing

Add coverage for slow multi-envelope reports, deadline-aware retries, skipped
attachments, rate-limit handling, and concurrency-slot release after failures.

## Why

Diagnostic reports can span several envelopes, and the previous 10-second shared
network budget could expire before slow uploads and their attachments completed.

## What changed

- Give each diagnostic report a single five-minute deadline shared by the event,
  attachments, retries, and retry backoff.
- Stop reading or sending later attachments once the deadline or a Sentry rate
  limit is reached.
- Limit the app server to three concurrent report uploads and return an
  overloaded JSON-RPC error for additional requests until a slot is released.

## Testing

Add coverage for slow multi-envelope reports, deadline-aware retries, skipped
attachments, rate-limit handling, and concurrency-slot release after failures.

GitOrigin-RevId: bdacf6c9731df16d2763e204565986eb6d540233
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/bdacf6c9731df16d2763e204565986eb6d540233 branch from 9811ba3 to a17ee57 Compare September 1, 2026 16:50
@copyberry
copyberry Bot merged commit a17ee57 into main Sep 1, 2026
25 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/bdacf6c9731df16d2763e204565986eb6d540233 branch September 1, 2026 16:51
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants