Allow updating the approval reviewer for active turns - #42121
Merged
copyberry[bot] merged 1 commit intoSep 1, 2026
Merged
Conversation
## What changed - Add `approvalsReviewer` to the experimental `turn/settings/update` API. - Apply reviewer changes to subsequently captured steps and new background approval requests while preserving pending approvals and future-thread defaults. - Allow reviewer-only updates without `step_model_switching`, while continuing to enforce managed reviewer restrictions and model-required auto review. - Use an explicit live reviewer update for MCP approvals while retaining refreshed thread defaults for clients that have not set one. ## Testing - Cover switching between user and automatic review during a live turn, future-turn isolation, and managed-authority rejection. GitOrigin-RevId: e1216b09c6a7972c2c9eaf4955d8d57d60604ca1
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/e1216b09c6a7972c2c9eaf4955d8d57d60604ca1
branch
from
September 1, 2026 19:21
260befa to
9112564
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/e1216b09c6a7972c2c9eaf4955d8d57d60604ca1
branch
September 1, 2026 19:22
Henry0304
temporarily deployed
to
issue-triage
September 1, 2026 19:48 — with 
GitHub Actions
Inactive
Henry0304
temporarily deployed
to
issue-triage
September 1, 2026 19:48 — with
GitHub Actions
Inactive
Henry0304
temporarily deployed
to
issue-triage
September 1, 2026 19:48 — with
GitHub Actions
Inactive
Henry0304
temporarily deployed
to
issue-triage
September 1, 2026 19:49 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow updating the approval reviewer for active turns
What changed
approvalsReviewerto the experimentalturn/settings/updateAPI.step_model_switching, while continuing to enforce managed reviewer restrictions and model-required auto review.Testing