Skip to content

Scope session MCP approvals to app account links - #42133

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7dd88330b75de312469020d5892dfb2fa5d5fada
Sep 1, 2026
Merged

Scope session MCP approvals to app account links#42133
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7dd88330b75de312469020d5892dfb2fa5d5fada

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 1, 2026

Copy link
Copy Markdown

Scope session MCP approvals to app account links

Why

Remembering an app tool approval by connector and tool alone could reuse an
approval when the same tool was called with a different selected account.

What changed

Include the app link_id in MCP tool approval keys so remembered session
approvals apply only to the account link that was approved. Calls for another
link, or calls without a link selector, request their own approval.

Testing

Add an integration test covering calls across two link IDs and the legacy
no-selector case.

## Why

Remembering an app tool approval by connector and tool alone could reuse an
approval when the same tool was called with a different selected account.

## What changed

Include the app `link_id` in MCP tool approval keys so remembered session
approvals apply only to the account link that was approved. Calls for another
link, or calls without a link selector, request their own approval.

## Testing

Add an integration test covering calls across two link IDs and the legacy
no-selector case.

GitOrigin-RevId: 7dd88330b75de312469020d5892dfb2fa5d5fada
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/7dd88330b75de312469020d5892dfb2fa5d5fada branch from 2a044f4 to 2393b5c Compare September 1, 2026 20:47
@copyberry
copyberry Bot merged commit 2393b5c into main Sep 1, 2026
26 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/7dd88330b75de312469020d5892dfb2fa5d5fada branch September 1, 2026 20:48
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant