fix: expose the scripted sandbox session type - #4406
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd88ffa024
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "canonical_module": "agents.testing.sandbox", | ||
| "canonical_name": "ScriptedSandboxSession", | ||
| "module": "agents.testing", | ||
| "name": "ScriptedSandboxSession" | ||
| }, |
There was a problem hiding this comment.
When the next released API contract is generated, this entry preserves only the canonical import identity; the generator deliberately does not infer properties. Because calls and remaining_steps are part of the newly exposed result interface but are absent from public_properties, the frozen contract will not detect their later removal or renaming. Add both properties to the policy entry for agents.testing.ScriptedSandboxSession.
Useful? React with 👍 / 👎.
dd88ffa to
33a7b5f
Compare
This pull request fixes the pre-release typing surface for scripted sandbox sessions.
scripted_sandbox_session()now returns a public abstractScriptedSandboxSessionthat retains nominalBaseSandboxSessioncompatibility while exposingcalls,remaining_steps, andassert_complete().The private implementation continues to own normalized-step construction, so internal machinery does not become part of the public API. The change also explicitly types the scripted-call exception metadata and records the canonical re-export in the prospective API contract policy for v0.21.0.