feat(api): Add shell call streaming events and image partial fields - #868
Conversation
Castiron-Internal-PR: openai/openai-java-internal#23 Castiron-Source-SHA: 01847344482205f48807d688df6baca9de286f5e Castiron-Public-Base-SHA: fcdcc7e
OkTest Summary🟡 Running for Java SDK PR #868. SDK merge (pending) · head ( |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Two merge-blocking issues remain on this generated promotion:
-
The stable/beta stream and server Visitor interfaces gain five abstract methods. Existing source implementations stop compiling; old binaries can throw AbstractMethodError when a new shell event dispatches, rather than reaching the existing unknown fallback. Please change the generator to emit real JVM-default implementations for newly added cases through a common fallback, and add source plus precompiled-binary compatibility fixtures. Verify the generated bytecode contains default methods.
-
The direct FunctionShellCallOutputContent component ref is emitted as a second public nested Output/Outcome/Exit graph, creating new 1,183- and 1,386-line event files. Please fix the generator model-name/reference overlay so the event reuses ResponseFunctionShellCallOutputContent and its beta peer, regenerate the shared models with optional created_by, and avoid handwritten generated-file splitting.
Low thermo follow-up: the generated union tests add an exhaustive negative-accessor matrix, growing stable 7,533→8,310 and beta 8,189→9,026 for five variants. Please move that invariant to a shared/parameterized generator template rather than continuing quadratic growth.
Summary
Add new shell-call streaming event models and ResponseStreamEvent accessors, add optional image partial metadata fields, and add a new audit-log event kind. Existing Responses WebSocket event types remain available; custom event Visitor implementations must handle the new shell-event cases.
Changes