Skip to content

feat(api): Add shell call streaming events and image partial fields - #868

Merged
apcha-oai merged 2 commits into
mainfrom
castiron/promotions/pr-23
Aug 17, 2026
Merged

feat(api): Add shell call streaming events and image partial fields#868
apcha-oai merged 2 commits into
mainfrom
castiron/promotions/pr-23

Conversation

@apcha-oai

Copy link
Copy Markdown
Contributor

Summary

Add new shell-call streaming event models and ResponseStreamEvent accessors, add optional image partial metadata fields, and add a new audit-log event kind. Existing Responses WebSocket event types remain available; custom event Visitor implementations must handle the new shell-event cases.

Changes

  • Keep structured chat-completion metadata accessors in sync and preserve missing-value handling through R8/ProGuard.
  • Introduce new streaming event models for shell calls: ResponseShellCallCommandAddedEvent, ResponseShellCallCommandDeltaEvent, ResponseShellCallCommandDoneEvent, ResponseShellCallOutputContentDeltaEvent, ResponseShellCallOutputContentDoneEvent (and beta counterparts).
  • Add ResponseStreamEvent factory/accessor methods for shell-call events (ofShellCallCommandAdded/Delta/Done and ofShellCallOutputContentDelta/Done) so stream events can be created and queried for these types.
  • Add visitor methods in ResponseAccumulator to handle the new shell-call streaming event types so accumulated stream visitors can process them.
  • Extend BetaResponseImageGenCallPartialImageEvent and ResponseImageGenCallPartialImageEvent with new optional fields background, output_format, quality, and size and expose typed getters for these fields.
  • Add TENANT_ADS_ACCOUNT_ONBOARDING_REDEMPTION as a new audit log event kind in AuditLogListParams and AuditLogListResponse.

Castiron-Internal-PR: openai/openai-java-internal#23
Castiron-Source-SHA: 01847344482205f48807d688df6baca9de286f5e
Castiron-Public-Base-SHA: fcdcc7e
@apcha-oai
apcha-oai marked this pull request as ready for review August 17, 2026 05:39
@apcha-oai
apcha-oai requested a review from a team as a code owner August 17, 2026 05:40
@apcha-oai
apcha-oai enabled auto-merge (squash) August 17, 2026 05:40
@openai-sdks

openai-sdks Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

🟡 Running for Java SDK PR #868.

View OkTest run #32048080810

SDK merge (pending) · head (6d9ce7248dc7) · base (0ede78d9c813) · OkTest (7e7850017529)

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two merge-blocking issues remain on this generated promotion:

  1. The stable/beta stream and server Visitor interfaces gain five abstract methods. Existing source implementations stop compiling; old binaries can throw AbstractMethodError when a new shell event dispatches, rather than reaching the existing unknown fallback. Please change the generator to emit real JVM-default implementations for newly added cases through a common fallback, and add source plus precompiled-binary compatibility fixtures. Verify the generated bytecode contains default methods.

    fun visitShellCallCommandAdded(shellCallCommandAdded: ResponseShellCallCommandAddedEvent): T

  2. The direct FunctionShellCallOutputContent component ref is emitted as a second public nested Output/Outcome/Exit graph, creating new 1,183- and 1,386-line event files. Please fix the generator model-name/reference overlay so the event reuses ResponseFunctionShellCallOutputContent and its beta peer, regenerate the shared models with optional created_by, and avoid handwritten generated-file splitting.

Low thermo follow-up: the generated union tests add an exhaustive negative-accessor matrix, growing stable 7,533→8,310 and beta 8,189→9,026 for five variants. Please move that invariant to a shared/parameterized generator template rather than continuing quadratic growth.

@apcha-oai
apcha-oai disabled auto-merge August 17, 2026 16:55
@apcha-oai
apcha-oai enabled auto-merge (squash) August 17, 2026 16:55
@apcha-oai
apcha-oai merged commit 9d0c42d into main Aug 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants