Skip to content

Honor Vite's build.write setting - #7

Open
fallintoplace wants to merge 2 commits into
openai:mainfrom
fallintoplace:fix/honor-vite-write-false
Open

fallintoplace wants to merge 2 commits into
openai:mainfrom
fallintoplace:fix/honor-vite-write-false

Conversation

@fallintoplace

Copy link
Copy Markdown

Why

Vite can run a build with build.write disabled to keep generated output in memory. The plugin currently creates dist/.openai from closeBundle anyway, leaving files behind when no build output should be written.

What changed

  • Package Sites metadata from writeBundle, which only runs when Vite writes output.
  • Add a real Vite build test covering build.write: false.

Test plan

  • pnpm check
  • git diff --check

@alecbarber-oai alecbarber-oai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants