Add CandidateAuthorization and enforce hidden-candidate access checks#827
Closed
RussH wants to merge 1 commit into
Closed
Add CandidateAuthorization and enforce hidden-candidate access checks#827RussH wants to merge 1 commit into
RussH wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
CandidateAuthorizationhelper class withgetCandidate,canAccessCandidate,getAttachment, andcanAccessCandidateAttachmentmethods to encapsulate object-level access logic.AttachmentsUI::getAttachmentto usecanAccessCandidateAttachmentand useisset($rs['attachmentID'])to validate attachment records before serving downloads.enforceCandidateHiddenAccessandenforceAttachmentCandidateHiddenAccesshelper methods toCandidatesUIand call them at all candidate- and attachment-related entry points (edit, delete, attachments create/delete/view, activity/status changes, tagging, pipelines, resume preview, questionnaire, image operations, and bulk operations) to abort with permission errors when appropriate.modules/lists/ajax/addToLists.phpto verify candidate access before adding candidate items to saved lists.Testing