Skip to content

[decomposed] test(api): remove passing notification tests from expected failure - #3555

Merged
v-scharf merged 2 commits into
mainfrom
test/pasing-notify-tests
Sep 23, 2026
Merged

v-scharf merged 2 commits into
mainfrom
test/pasing-notify-tests

Conversation

@saw-jan

@saw-jan saw-jan commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

Remove passing test scenarios from the expected failure list.
Test suite: apiNotification
Storage: decomposed

[ERROR] Total unexpected passed scenarios:
- apiNotification/emailNotification.feature:280
- apiNotification/emailNotification.feature:298
- apiNotification/spaceNotification.feature:463

Summary: 66 scenarios (66 passed, 0 failed)

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan saw-jan self-assigned this Sep 17, 2026
@codacy-production

codacy-production Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage 0.00% diff coverage

Metric Results
Coverage variation Report missing for 071d8591
Diff coverage ✅ 0.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (071d859) Report Missing Report Missing Report Missing
Head commit (aeca4c4) 88661 21417 24.16%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3555) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@saw-jan
saw-jan requested a review from v-scharf September 17, 2026 07:21
@saw-jan

saw-jan commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

need to fix the cli-decomposed test suite failure.

@v-scharf
v-scharf enabled auto-merge (squash) September 17, 2026 12:02
@saw-jan

saw-jan commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@v-scharf, is your chat/matrix down? Couldn't reach you.

@v-scharf

Copy link
Copy Markdown
Contributor

@v-scharf, is your chat/matrix down? Couldn't reach you.

it works, I can chat with opencloud people. But I haven't received any messages from you.

@saw-jan

saw-jan commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor Author

@v-scharf, is your chat/matrix down? Couldn't reach you.

it works, I can chat with opencloud people. But I haven't received any messages from you.

hmmm, that's strange. It says the messages are delivered from my side.

Screenshot from 2026-09-18 16-10-35

@saw-jan
saw-jan marked this pull request as draft September 22, 2026 07:21
auto-merge was automatically disabled September 22, 2026 07:21

Pull request was converted to draft

@saw-jan

saw-jan commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

@v-scharf, this is the failure - cannot find the trashed empty dirs. Is this the known failure?

  Scenario: delete empty trashbin folders                                   # /woodpecker/src/github.com/opencloud-eu/opencloud/tests/acceptance/features/cliCommands/cleanupEmptyTrashBin.feature:5
    Given user "Alice" has been created with default attributes             # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    And user "Alice" has created the following folders                      # FeatureContext::userHasCreatedFollowingFolders()
      | path              |
      | folder-to-delete  |
      | folder-to-restore |
    And user "Alice" has deleted the following resources                    # FeatureContext::userHasDeletedFollowingFiles()
      | path              |
      | folder-to-delete  |
      | folder-to-restore |
    When the administrator deletes the empty trashbin folders using the CLI # CliContext::theAdministratorDeletesEmptyTrashbinFoldersUsingTheCli()
    Then the command should be successful                                   # CliContext::theCommandShouldBeSuccessful()
      {"level":"error","error":"unknown edition channel ''","time":"2026-09-17T12:14:37.617722666Z","caller":"/go/src/github.com/opencloud-eu/opencloud/pkg/version/version.go:55","message":"falling back to dev"}
      no trash found. Double check storage path
      no trash found. Double check storage path
      
      Failed asserting that two strings are identical.
      --- Expected
      +++ Actual
      @@ @@
      -'OK'
      +'ERROR'

@v-scharf

v-scharf commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

@v-scharf, this is the failure - cannot find the trashed empty dirs. Is this the known failure?

fixed, at least works localy (with posix and with decomposed):

STORAGE_DRIVER='decomposed' BEHAT_FEATURE='tests/acceptance/features/cliCommands/cleanupEmptyTrashBin.feature:5' make -C tests/acceptance/docker run-api-tests

acceptance-tests-1  | Script path: /woodpecker/src/github.com/opencloud-eu/opencloud/tests/acceptance/scripts
acceptance-tests-1  | Running cliCommands tests tagged ~@skip
acceptance-tests-1  | Using behat config 'tests/acceptance/config/behat.yml'
acceptance-tests-1  | @env-config
acceptance-tests-1  | Feature: delete empty trash bin folder via CLI command
acceptance-tests-1  | 
acceptance-tests-1  |   Scenario: delete empty trashbin folders    # /woodpecker/src/github.com/opencloud-eu/opencloud/tests/acceptance/features/cliCommands/cleanupEmptyTrashBin.feature:5
acceptance-tests-1  |     Given user "Alice" has been created with default attributes    # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
acceptance-tests-1  |     And user "Alice" has created the following folders    # FeatureContext::userHasCreatedFollowingFolders()
acceptance-tests-1  |       | path              |
acceptance-tests-1  |       | folder-to-delete  |
acceptance-tests-1  |       | folder-to-restore |
acceptance-tests-1  |     And user "Alice" has deleted the following resources    # FeatureContext::userHasDeletedFollowingFiles()
acceptance-tests-1  |       | path              |
acceptance-tests-1  |       | folder-to-delete  |
acceptance-tests-1  |       | folder-to-restore |
acceptance-tests-1  |     When the administrator deletes the empty trashbin folders using theCLI # CliContext::theAdministratorDeletesEmptyTrashbinFoldersUsingTheCli()
acceptance-tests-1  |     Then the command should be successful    # CliContext::theCommandShouldBeSuccessful()
acceptance-tests-1  | 
acceptance-tests-1  | 1 scenario (1 passed)
acceptance-tests-1  | 5 steps (5 passed)
acceptance-tests-1  | 0m8.13s (25.16Mb)

@v-scharf
v-scharf requested a review from maki5 September 23, 2026 14:01
@v-scharf
v-scharf marked this pull request as ready for review September 23, 2026 14:05
@v-scharf

Copy link
Copy Markdown
Contributor
Screenshot from 2026-09-18 16-10-35

#3580

@v-scharf
v-scharf enabled auto-merge (squash) September 23, 2026 14:27
@v-scharf
v-scharf merged commit 8b024b8 into main Sep 23, 2026
63 checks passed
@v-scharf
v-scharf deleted the test/pasing-notify-tests branch September 23, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants