Skip to content

Fix delete stale nodes command - #3593

Draft
butonic wants to merge 5 commits into
mainfrom
port-11707
Draft

butonic wants to merge 5 commits into
mainfrom
port-11707

Conversation

@butonic

@butonic butonic commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

This PR fixes the delete stale nodes command to properly handle node cleanup by implementing event-driven revert operations instead of direct file system deletion. The fix ensures that stale processing nodes are properly rolled back through the event system rather than being forcefully removed.

  • Replaces direct file deletion with event-based revert revision mechanism
  • Updates function signatures to accept an event stream parameter
  • Adds resource ID extraction functionality for proper event handling
  • Adds documentation

builds on opencloud-eu/reva#821 and contains a reva bump

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@codacy-production

codacy-production Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 42 complexity

Metric Results
Complexity 42

View in Codacy

🟢 Coverage 0.00% diff coverage · -0.03% coverage variation

Metric Results
Coverage variation ✅ -0.03% coverage variation (-1.00%)
Diff coverage ✅ 0.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (040c3bf) 89085 21490 24.12%
Head commit (bff0977) 89250 (+165) 21504 (+14) 24.09% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3593) 165 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

…tion

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic self-assigned this Sep 24, 2026
@butonic butonic added the Type:Maintenance E.g. technical debt, packaging, etc. label Sep 24, 2026
@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Sep 24, 2026
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Restore the versionID-based antivirus revert in upload.Cleanup and
make RevertCurrentRevision/getLatestRevision layout-aware via
PathLookup.VersionPath, fixing the posix posixfs
@issue-enterprise-5709 antivirus revert regression introduced by the
port of owncloud/reva PR #409.

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

Status: Qualification

Development

Successfully merging this pull request may close these issues.

1 participant