Conversation
…ueue The uploads sessions command builds a posix driver with async file uploads enabled, which makes it join the "dcfs" JetStream queue group. Clean/restart/resume events published by the command itself can then be routed to the CLI's own short-lived consumer; the nats client auto-acks them and they are lost when the process exits, leaving stale upload sessions behind. Disable asyncfileuploads for the CLI driver instance so it only lists sessions and publishes events. Also emit [] instead of null when the session list is empty so the JSON output stays parseable.
The AfterScenario hook only asserted that the clean command returned 200, but cleaning sessions happens asynchronously in the daemon. Poll the session list until it is empty (60s deadline) so leftover sessions do not leak into the next scenario.
butonic
force-pushed
the
fix/uploads-cli-no-async-consumer
branch
from
September 25, 2026 15:34
7d7b503 to
eab5eb3
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 0.00% diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation (-1.00%) Diff coverage ✅ 0.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f7e6d5d) 89085 21492 24.13% Head commit (eab5eb3) 89090 (+5) 21502 (+10) 24.14% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3603) 10 0 0.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
butonic
marked this pull request as ready for review
September 25, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after merging #3591 the tests became flaky because the cli no longer waits for the command to finish - and there cli command would register itself as a consumer for the main-queue. with the event based approach this could lead to the cli itself consuming the event and then killing itself ... losing the event in the process.