fix: encode hash character in app route URLs to prevent truncation

packages/web-pkg/src/composables/actions/files/useFileActions.ts

@@ -184,8 +184,8 @@ export const useFileActions = () => {
     if (!routeName || !router.hasRoute(routeName)) {
       return null
     }
-    const routeOpts = getEditorRouteOpts(routeName, space, resource, remoteItemId)
-    return router.resolve(routeOpts)
+
+    return getEditorRouteOpts(routeName, space, resource, remoteItemId)
   }
   const getEditorRouteOpts = (
     routeName: RouteRecordName,

packages/web-pkg/tests/unit/composables/actions/files/useFileActions.spec.ts

@@ -103,12 +103,51 @@ describe('fileActions', () => {
         }
       })
       mocks.$router.hasRoute.mockReturnValue(true)
+
+      const mockSpace = mock<SpaceResource>({
+        getDriveAliasAndItem: () => 'personal/admin/test.txt'
+      })
+
       const result = editorAction.route({
-        space: mock<SpaceResource>(),
+        space: mockSpace,
         resources: actionOptions.resources
       })
       expect(result).not.toBeNull()
     })
+
+    it('returns unresolved route options so the router encodes the path', () => {
+      let editorAction: FileAction
+      const { mocks } = getWrapper({
+        setup: ({ getAllOpenWithActions }) => {
+          const actions = getAllOpenWithActions(actionOptions)
+          editorAction = actions.find((a) => a.name === 'editor-text-editor')
+        }
+      })
+      mocks.$router.hasRoute.mockReturnValue(true)
+
+      const mockSpace = mock<SpaceResource>({
+        getDriveAliasAndItem: () => 'personal/admin/ticket#1234/logs.txt'
+      })
+      const mockResource = mock<Resource>({
+        path: '/ticket#1234/logs.txt',
+        fileId: 'test-file-id'
+      })
+
+      const route = editorAction.route({
+        space: mockSpace,
+        resources: [mockResource]
+      })
+
+      // Resolving is left to the router. Handing it an already resolved location
+      // or a pre-encoded path both break the encoding of characters like `#`.
+      expect(route).toEqual(
+        expect.objectContaining({
+          name: 'text-editor',
+          params: { driveAliasAndItem: 'personal/admin/ticket#1234/logs.txt' }
+        })
+      )
+      expect(route).not.toHaveProperty('href')
+    })
   })
 
   describe('secure view context', () => {