fix: define the shimmer animation start frame - #3263
Closed
fredrikblau wants to merge 1 commit into
Closed
fredrikblau wants to merge 1 commit into
fredrikblau wants to merge 1 commit into
Conversation
Member
|
It seems you also included this in #3264, so I'm closing here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The shared shimmer animation only declares its ending transform and relies on a utility class to provide the initial state. That implicit starting frame is not consistently retained by browsers, and the loading indicator can fail to animate correctly.
Define the
0%transform in the keyframes so the shimmer has an explicit, portable start state.Related Issue
How Has This Been Tested?
pnpm lintpnpm format:checkTypes of changes