You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On narrow windows the editor toolbar exposes items through horizontal scrolling, but users with a mouse without horizontal scrolling have no obvious way to reach them.
Add accessible left and right controls whenever the toolbar overflows. Each control scrolls the toolbar by 75% of its visible width, while the existing native scrolling remains available.
Could you try to improve the visual appearance of this feature ?
The scroll bar is now showing up while using the < > buttons and is quite near to the toolbar, therefore the UI looks very cluttered.
The < > buttons do overflow the other toolbar items making them hard to see and operate. Could think of multiple ways to solve it e.G giving the toolbar a padding left and right when the < > buttons are displayed or giving them a background with a drop shadow to either right or left.
Whatever works best 馃憤
Addressed the toolbar feedback: hid the native scrollbar, added side padding, and gave the scroll controls a surface/shadow so they remain usable over toolbar items. Targeted test, Prettier, and ESLint pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On narrow windows the editor toolbar exposes items through horizontal scrolling, but users with a mouse without horizontal scrolling have no obvious way to reach them.
Add accessible left and right controls whenever the toolbar overflows. Each control scrolls the toolbar by 75% of its visible width, while the existing native scrolling remains available.
Related Issue
How Has This Been Tested?
pnpm test:unit --run packages/web-pkg/tests/unit/editor/components/TextEditorToolbar.spec.tspnpm check:typespnpm lintpnpm format:checkTypes of changes