Skip to content

fix: add emoji slash entry and tighten emoji picker modal width - #3310

Merged
kulmann merged 1 commit into
mainfrom
fix/slash-menu-emoji-icon-and-modal-width
Sep 8, 2026
Merged

kulmann merged 1 commit into
mainfrom
fix/slash-menu-emoji-icon-and-modal-width

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Sep 5, 2026 •

Copy link
Copy Markdown
Member

Description

This bugfix addresses two editor UX issues around emoji insertion:

  • Adds the missing emoji insert entry (with icon) to slash commands.
  • Fixes emoji picker modal sizing so the modal follows picker dimensions instead of rendering wider than the picker.
  • Applies the modal-width behavior consistently, including the Set Space Icon flow.

Related Issue

  • Fixes n/a (no tracking issue provided)

How Has This Been Tested?

  • test environment: local dev environment on macOS
  • test case 1: pnpm check:types
  • test case 2: pnpm test:unit --run packages/web-pkg/tests/unit/editor/composables/useEditorActions.spec.ts packages/web-pkg/tests/unit/editor/composables/useTextEditor.spec.ts packages/web-pkg/tests/unit/editor/strategies/html.spec.ts packages/web-pkg/tests/unit/editor/strategies/markdown.spec.ts packages/web-pkg/tests/unit/editor/strategies/tiptapJson.spec.ts packages/web-app-files/tests/unit/composables/actions/spaces/useSpaceActionsSetIcon.spec.ts

Types of changes

  • Bugfix
  • Enhancement (a change that does not break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear requested a review from kulmann September 5, 2026 01:53
@AlexAndBear AlexAndBear self-assigned this Sep 5, 2026
@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Sep 5, 2026
@AlexAndBear AlexAndBear moved this from Qualification to Blocked in OpenCloud Team Board Sep 5, 2026
@AlexAndBear AlexAndBear moved this from Blocked to In Progress in OpenCloud Team Board Sep 5, 2026
@kulmann
kulmann merged commit a62207d into main Sep 8, 2026
31 of 32 checks passed
@kulmann
kulmann deleted the fix/slash-menu-emoji-icon-and-modal-width branch September 8, 2026 10:13
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenCloud Team Board Sep 8, 2026
@openclouders openclouders mentioned this pull request Sep 8, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants