Skip to content

fix: restore redo for collaborative text editor - #3360

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/tiptap-collaboration-redo
Sep 14, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/tiptap-collaboration-redo

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Configures the Tiptap Collaboration extension with the Yjs UndoManager as a tracked origin. This keeps undo operations in the collaboration history so they create redo entries, restoring redo for collaborative text editor sessions while keeping toolbar and keyboard shortcuts on Tiptap's standard undo / redo commands.

Adds regression coverage for collaborative history, UndoManager-origin tracking, and the toolbar redo button becoming enabled after undo.

Related Issue

How Has This Been Tested?

  • test environment: local unit test environment with Vitest and happy-dom, run via pnpm.
  • test case 1: pnpm test:unit --run packages/web-pkg/tests/unit/editor/composables/useEditorActions.spec.ts packages/web-pkg/tests/unit/editor/composables/useTextEditor.spec.ts packages/web-pkg/tests/unit/editor/components/TextEditorToolbar.spec.ts
  • test case 2: pnpm check:types
  • test case 3: pnpm exec eslint packages/web-pkg/src/editor/composables/useEditorActions.ts packages/web-pkg/src/editor/composables/useTextEditor.ts packages/web-pkg/tests/unit/editor/composables/useTextEditor.spec.ts packages/web-pkg/tests/unit/editor/components/TextEditorToolbar.spec.ts --color
  • test case 4: pnpm exec prettier packages/web-pkg/src/editor/composables/useEditorActions.ts packages/web-pkg/src/editor/composables/useTextEditor.ts packages/web-pkg/tests/unit/editor/composables/useTextEditor.spec.ts packages/web-pkg/tests/unit/editor/components/TextEditorToolbar.spec.ts --config packages/prettier-config/index.js --check

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear force-pushed the fix/tiptap-collaboration-redo branch from b7ad365 to d68e3fa Compare September 14, 2026 12:09
@AlexAndBear
AlexAndBear merged commit 2d3bddb into main Sep 14, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/tiptap-collaboration-redo branch September 14, 2026 12:44
@openclouders openclouders mentioned this pull request Sep 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tiptap redo is broken

2 participants