Skip to content

feat(runtime): sync auto theme with system preference changes - #3363

Merged
kulmann merged 1 commit into
mainfrom
feat/3315-auto-system-theme-sync
Sep 14, 2026
Merged

kulmann merged 1 commit into
mainfrom
feat/3315-auto-system-theme-sync

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Description

  • react to system dark/light preference changes at runtime when the user selected auto theme mode
  • call themeStore.setAutoSystemTheme() only when themeStore.isCurrentThemeAutoSystem is enabled

Related Issue

How Has This Been Tested?

  • test environment: local workspace (/Users/a.ackermann/working/web), Node 24, pnpm 11
  • test case 1: pnpm eslint packages/web-runtime/src/index.ts --color
  • test case 2: pnpm test:unit --run packages/web-pkg/tests/unit/composables/piniaStores/theme.spec.ts
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear force-pushed the feat/3315-auto-system-theme-sync branch from a2ed0bd to c574fec Compare September 14, 2026 12:09

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy 馃槏

@kulmann
kulmann merged commit d219ddb into main Sep 14, 2026
31 checks passed
@kulmann
kulmann deleted the feat/3315-auto-system-theme-sync branch September 14, 2026 12:59
@openclouders openclouders mentioned this pull request Sep 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt to system light/dark mode instantly without requiring refresh

2 participants