Skip to content

Revert "fix: remove pasted text/background colors in Tiptap editor" - #3385

Merged
AlexAndBear merged 1 commit into
mainfrom
revert-pr-3275-tiptap-paste-colors
Sep 16, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
revert-pr-3275-tiptap-paste-colors

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Reverts #3275 because stripping text and background colors from pasted HTML also removes those colors when users copy selected text from our editor. That loses existing editor formatting in a case where users would not expect it, which is too large a downside for this behavior.

Specifically, this removes the pasted HTML color-stripping helper, its export, the Tiptap transformPastedHTML hook, and the related unit test.

Related Issue

How Has This Been Tested?

  • test environment: local macOS development environment, pnpm + vitest
  • test case 1: pnpm --config.confirmModulesPurge=false test:unit --run packages/web-pkg/tests/unit/editor/composables/useTextEditor.spec.ts
  • test case 2: confirmed there are no remaining references to stripColorFormattingFromPastedHtml or transformPastedHTML in the editor package
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Sep 16, 2026
@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Sep 16, 2026
@AlexAndBear
AlexAndBear requested a review from kulmann September 16, 2026 01:12
@AlexAndBear AlexAndBear moved this from Qualification to In Progress in OpenCloud Team Board Sep 16, 2026
@AlexAndBear
AlexAndBear merged commit ae8d537 into main Sep 16, 2026
32 checks passed
@AlexAndBear
AlexAndBear deleted the revert-pr-3275-tiptap-paste-colors branch September 16, 2026 08:05
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenCloud Team Board Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants