Repository navigation
feat: filter favorites by tags and always show the tag filter - #3554
Merged
Merged
Conversation
2 tasks done
AlexAndBear
force-pushed
the
feat/favorites-tag-filter
branch
from
October 5, 2026 12:54
18a1b0d to
ea3c097
Compare
kulmann
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a tag filter to the favorites view, like the one in the search results. Favorites are already loaded through the search (
is:favorite), so the selected tags are just another condition of that query.loaderFavorites.tsreadsq_tagsand addstag:("a" OR "b")to the search query, the same syntax the search usesFavorites.vueshows a "Tags" filter between "Type" and "Last Modified" (multiple selection, searchable), with the tags fromgraph.tags.listTags(). It's only shown if the server supports tags (capabilityStore.filesTags), the tags load in parallel to the favoritesItemFilter.vuegot an optionalnoItemsMessagethat replaces the empty list and the option filterq_tagsreloads the favorites and counts as an active filter for the empty state hintloaderFavorites.spec.ts) and the viewNo tags yet
Related Issue
How Has This Been Tested?
pnpm vite) against the docker-compose backend, Chromium at 1440px and 412pxq_tags=favtestand the search request istag:("favtest") AND is:favoritepnpm test:unit --run packages/web-app-files packages/web-pkg,vue-tsc --noEmitTypes of changes